Update: minor popover clarification #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to acknowledge there are different popover states (manual, auto/empty-string, and the proposed hint) this minor update clarifies that the minimum role of group applies to all popover states. Is it worth also adding this note, or something like it? There are no unique mappings for different popover states. Any additional accessibility mapping changes would be the responsibility of the author. e.g, using different base HTML elements, attributes, or ARIA attributes to make such changes.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adampage
approved these changes
Nov 25, 2024
Co-authored-by: Adam Page <[email protected]>
scottaohara
commented
Nov 25, 2024
add note
4 tasks
smhigley
approved these changes
Jan 10, 2025
|
@rahimabdi once you give this a look over, and if you have nothing to add/change, then we can merge. |
|
LGTM @scottaohara , thank you! |
rahimabdi
approved these changes
Jan 10, 2025
|
@spectranaut @jnurthen - while i merged this, i think there may be something off with publishing? looking at the failure - https://github.com/w3c/aria/actions/runs/12718859000/job/35458034879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to acknowledge there are different popover states (manual, auto/empty-string, and the proposed hint) this minor update clarifies that the minimum role of group applies to all popover states.
Is it worth also adding this note, or something like it?
There are no unique mappings for different popover states. Any additional accessibility mapping changes would be the responsibility of the author. e.g, using different base HTML elements, attributes, or ARIA attributes to make such changes.