-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: change default role for custom elements #2383
Open
scottaohara
wants to merge
14
commits into
main
Choose a base branch
from
custom-element-role-change
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−55
Open
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4fbb93f
Update: change default role for custom elements
scottaohara 8bde5fd
fix typo / missing in-page link id
scottaohara 9e6c5b2
Update html-aam/index.html
scottaohara d1fffc8
Update html-aam/index.html
scottaohara a3ee851
Update html-aam/index.html
scottaohara 584d952
update per feedback/discussion about referenced elements
scottaohara 88b0dc0
Update index.html
scottaohara 90cbd15
Update html-aam/index.html
scottaohara 89b18fb
Update html-aam/index.html
scottaohara ec41dfc
or else if otherwise sure?
scottaohara 07fa950
combining things
scottaohara 67ce536
add in no shadow root use cae
scottaohara b37c79b
Update html-aam/index.html
scottaohara 691877f
Update html-aam/index.html
scottaohara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I conceded excluding
aria-roledescription
ongeneric
a while back, though I don't fully agree... Addingnone
to the list of exclusions is probably okay, too.However, excluding it on all host language native roles is not okay.