Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-overflow-4] Draft spec for
continue: collapse
(#7708) #10816base: main
Are you sure you want to change the base?
[css-overflow-4] Draft spec for
continue: collapse
(#7708) #10816Changes from 3 commits
c2fa930
c7df9c9
1699d89
ee8fab9
178c050
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with that, but I think this has been controversial, with some advocating that the displaced content be dropped / invisible instead, in order to avoid that inserting the ellipsis would cause an extra layout pass. Should we open a separate issue to discuss that aspect?
Or maybe this is unavoidable due to bidi processing of the ellipsis, which means we have to relayout anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bidi processing of the ellipsis would make it unavoidable to relayout at least that line, but not necessarily the lines after it. But if we only do that line, then there could be inline elements that end up falling out of the layout if they now don't fit in the line with the ellipsis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I understand what the difference/benefit is of placing a clamp point at the end, instead of saying there's no clamp point. We can define that a clamp point at the end has no effect (which I what I believe the later definition does), but would it not be simpler to just say that there isn't one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a clamp point at the end because, for
line-clamp: auto
, that is enough to explain the lack of visible clamping when the max-height is larger than the box's auto size. The last clamp point that fits is the clamp point at the end, which is visually equivalent to no clamping.I don't feel strongly about this, though, so we could change this to not have a clamp point at the end, as long as we also say that the last line doesn't have a following clamp point (maybe unless it's followed by non-inline content, depending on whether we allow clamping between lineless blocks).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we make it work on multicols too? Is there any particular difficulty in inserting a clamp point after N lines or after the last line of the last non-overflow column, and hiding overflow columns in any case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In inserting a clamp point after N lines, no. For adding it in the last line of the last non-overflowing column, at least in my implementation in Chromium it might not be easy, because the machinery to figure out whether a line is the last line that doesn't overflow, including accounting for border/padding/margin, would have to interact with the fragmentation machinery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in an earlier comments, I am not sure I understand what the difference/benefit is of placing a clamp point at the end, instead of saying there's no clamp point. We can define that a clamp point at the end has no effect (which I what I believe the definition bellow does), but would it not be simpler to just say that there isn't one?