Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DID Parameters section from did-core to did-resolution. #106

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

peacekeeper
Copy link
Collaborator

@peacekeeper peacekeeper commented Dec 18, 2024

This adds the "DID Parameters" section to did-resolution. Also see the "matching" PR in did-core: w3c/did-core#872


Preview | Diff

@w3cbot
Copy link

w3cbot commented Dec 19, 2024

This was discussed during the #did meeting on 19 December 2024.

View the transcript

w3c/did-core#872 and this w3c/did-resolution#106

markus_sabadello: I created a PR in did-core and a corresponding PR in did-resolution to move the parameters section from did-core to did-resolution,
… as we discussed last time.

<Wip> This w3c/did-core#872 and this w3c/did-resolution#106


Comment on lines +289 to +292
A resource hash of the <a>DID document</a> to add integrity protection, as
specified in [[?HASHLINK]]. This parameter is non-normative.
If present, the associated value MUST be an
<a data-lt="ascii string">ASCII string</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but I wonder if we should just define hashlinks in this spec given that we have Multihash defined in CID now?

@w3cbot
Copy link

w3cbot commented Jan 9, 2025

This was discussed during the #did meeting on 09 January 2025.

View the transcript

w3c/did-resolution#106

markus_sabadello: I think this would be ready to merge. There haven't been a lot of reviews but this is something we decided to do before the holidays.
… There's a list of parameters from DID Core that have been moved to DID Resolution.
… What should I do about these reviews? Just manually tag people?

wip: I don't know what's best. I can provide a review, and I have reviewed some.

manu: Manual reviews by just adding people would work for now. There may be a way to automate through the code owners file, but it may be an abuse of that file.

markus_sabadello: For now, I'll add people manually.


@peacekeeper
Copy link
Collaborator Author

Merging after multiple approvals.

@peacekeeper peacekeeper merged commit 507e13a into gh-pages Jan 15, 2025
2 checks passed
@peacekeeper peacekeeper deleted the peacekeeper-move-did-parameters branch January 15, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants