jump to specified position by hash, for environment with slow loading #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
requested changes
Oct 25, 2023
Comment on lines
+143
to
+146
| // jump to hash position after tree built | ||
| if (document.location.hash) { | ||
| var chash = document.location.hash; | ||
| document.location.hash = chash; |
There was a problem hiding this comment.
match file usage of tabs instead of spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can set position of display with hash in URL for sharing, but in some environment with e.g. slow loading, html with lists of fetched issue (h2 with table) will be build after display/jump operation finished - which causes hash not to be found and display kept at the top.
Re-adding hash after processing on list of issues by this PR could fix this.