This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
Added support for test flags to per-test metadata #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore empty metadata values
| @@ -338,6 +338,10 @@ var metadata_generator = { | |||
| showSource = true; | |||
| } | |||
| } | |||
| else if (1 < tests.length) { | |||
| // message = 'Cached metadata not present. '; | |||
There was a problem hiding this comment.
Those two lines were originally removed by Ms2ger as (s)he found the warning message annoying. I re-added the code but left the message disabled so those that wanted it could easily re-enable.
I'm working on an alternative system for gathering the metadata through Shepherd's API. So we may be able to remove the manual adding of the metadata cache soon (if it works out), although having it won't hurt anyway.
|
Is this still relevant? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is