This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
Make HTTPS tests fail if they are loaded over HTTP #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test files that contain ".https." trigger a check on the current protocol. If the current protocol is not "https:", all tests in this test file fail with a "Test page must be loaded over HTTPS" message.
Just throw an exception before any tests run, not inside |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces PR #207. Same goal: make the test harness fail HTTPS-only tests when they are loaded over HTTP with a "Test page must be loaded over HTTPS" message.
The new PR addresses the request from @jgraham to relax the check and look for
httpswithin the file name without assuming that the extension will be.html, and without assuminghttpswill be the last dot flag before the extension.Note I stuck to
indexOf(".https.")because I think that reads better than.split(".").slice(1).slice(0, -1).indexOf("https"). This should yield the same result.This change is