Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update G195 - removal of last line of test (low contrast OK if focus ring > 2px thick) #3686

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

detlevhfischer
Copy link
Contributor

@detlevhfischer detlevhfischer commented Feb 12, 2024

Deletion of last line of test procedure that indicated that contrast below 3:1 is OK if the focus ring is more than 2px thick

Closes #3682

Deletion of last line of test procedure that indicated that contrast below 3:1 is OK if the border is more than 2px thick
@patrickhlauke patrickhlauke self-assigned this Nov 8, 2024
@bruce-usab
Copy link
Contributor

Discussed on TF call 11/8 and moved to Ready for approval after Patrick offered to double check.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 48f360f
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/6749f500aa8823000878956f
😎 Deploy Preview https://deploy-preview-3686--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbgower
Copy link
Contributor

mbgower commented Nov 20, 2024

@patrickhlauke and @detlevhfischer please see my comments #3682 . I believe we need to decide whether we are to maintain two versions of G195. Either way, we need more changes in the Test (unless we are intentionally exceeding the Non-text Contrast requirements). Also, if we decide not to apply this technique to 2.4.13 in 2.2, we need to make adjustments to the Understanding document to remove the mapping.

@mbgower
Copy link
Contributor

mbgower commented Nov 21, 2024

@kfranqueiro I'm just bringing this one to your attention, as it may be relevant to your 2.1 update

@mbgower
Copy link
Contributor

mbgower commented Nov 25, 2024

Discussed on the TF admin call.
I will do the following:

  • rewrite the G195 test to be specific to meet Non-text Contrast (and focus visible)
  • remove the reference to G195 in the Focus Apperance Understanding document
  • investigate other techniques that attempt to meet both AA and AAA (e.g., G17 and G18)
  • open a new issue to draft a new technique to meet Focus Appearance
  • Consider the title and guidance in G195 and the new technique to ensure they are complementary but also distinctive

@alastc
Copy link
Contributor

alastc commented Nov 25, 2024

I agree with having two separate techniques:

  • G195 is for WCAG 2.1, and we remove the focus-appearance aspects.
  • G2xx for WCAG 2.2, which meets the focus-appearance one. Include a note at the top saying something like "This builds on G195 to cover Focus-Appearance".

This PR could be just for the first part, and separate the second one.

Remove cross-reference to G195 from AAA SC
Putting the pointer to G195 back into WCAG 2.2, as per my latest comment in the issue #3682 (comment)
Updating language of test to meet wording of 2.4.13 Focus Appearance
Modifying the second check to add in a contrast requirement to meet 1.4.11.
formatting
@mbgower
Copy link
Contributor

mbgower commented Nov 27, 2024

@alastc as per the comments in the issue, I found that if we can do it, it actually makes more sense to extend the test to meet Focus Appearance. If necessary, we can sever the connections from 2.1, but I have now made the test include a check that it meets 1.4.11 requirements, so even though the technique exceeds 1.4.11, it could still stay as being sufficient.

mbgower and others added 2 commits November 27, 2024 14:11
Small changes to make the text match the example on the page as well as the test criteria.
</ol>
</section>
<section class="results"><h3>Expected Results</h3>
<ul>
<li>Checks #2, #4, and #5 are true.</li>
<li>If Check #1 is true, all other checks are also true.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>If Check #1 is true, all other checks are also true.</li>
<li>If Check #1 is true, all other checks must also be true.</li>

@mbgower
Copy link
Contributor

mbgower commented Nov 29, 2024

@mbgower to check history of G195 and merge the first to test steps into the preamble
For each user interface component on the page that should receive keyboard focus:



  1. Check that the focus indicator or its background color has been modifed by the author

Updated test based on TF discussion
@bruce-usab
Copy link
Contributor

Discussed on TF call 12-6, facilitators to discuss on a coordination call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.4.7 / 1.4.11 Conflict between 1.4.11 Understanding text and G195 (author-supplied focus indicator)
5 participants