-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update G195 - removal of last line of test (low contrast OK if focus ring > 2px thick) #3686
base: main
Are you sure you want to change the base?
Conversation
Deletion of last line of test procedure that indicated that contrast below 3:1 is OK if the border is more than 2px thick
Discussed on TF call 11/8 and moved to Ready for approval after Patrick offered to double check. |
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@patrickhlauke and @detlevhfischer please see my comments #3682 . I believe we need to decide whether we are to maintain two versions of G195. Either way, we need more changes in the Test (unless we are intentionally exceeding the Non-text Contrast requirements). Also, if we decide not to apply this technique to 2.4.13 in 2.2, we need to make adjustments to the Understanding document to remove the mapping. |
@kfranqueiro I'm just bringing this one to your attention, as it may be relevant to your 2.1 update |
Discussed on the TF admin call.
|
I agree with having two separate techniques:
This PR could be just for the first part, and separate the second one. |
Remove cross-reference to G195 from AAA SC
Putting the pointer to G195 back into WCAG 2.2, as per my latest comment in the issue #3682 (comment)
Updating language of test to meet wording of 2.4.13 Focus Appearance
Modifying the second check to add in a contrast requirement to meet 1.4.11.
formatting
@alastc as per the comments in the issue, I found that if we can do it, it actually makes more sense to extend the test to meet Focus Appearance. If necessary, we can sever the connections from 2.1, but I have now made the test include a check that it meets 1.4.11 requirements, so even though the technique exceeds 1.4.11, it could still stay as being sufficient. |
Small changes to make the text match the example on the page as well as the test criteria.
techniques/general/G195.html
Outdated
</ol> | ||
</section> | ||
<section class="results"><h3>Expected Results</h3> | ||
<ul> | ||
<li>Checks #2, #4, and #5 are true.</li> | ||
<li>If Check #1 is true, all other checks are also true.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li>If Check #1 is true, all other checks are also true.</li> | |
<li>If Check #1 is true, all other checks must also be true.</li> |
@mbgower to check history of G195 and merge the first to test steps into the preamble
|
Updated test based on TF discussion
Discussed on TF call 12-6, facilitators to discuss on a coordination call. |
Deletion of last line of test procedure that indicated that contrast below 3:1 is OK if the focus ring is more than 2px thick
Closes #3682