Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading and unloading web extension in webdriver #1869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiaraarose
Copy link

@kiaraarose kiaraarose commented Dec 19, 2024

This is a pre-requisite to adding support for cross browser testing for web extensions. PR to test these new commands in WPT: web-platform-tests/wpt#49786


Preview | Diff

@OrKoN
Copy link
Contributor

OrKoN commented Dec 19, 2024

This functionality is already specified as part of WebDriver BiDi. Is there additional context for this PR? Unless there is a good reason, it does not sound like WebDriver specs should specify this twice.

…sic.

This is a pre-requisite to adding support for cross browser testing for web extensions.
PR to test these new commands in WPT: web-platform-tests/wpt#49786
@davidjohnson91
Copy link

@OrKoN Safari does not support WebDriver BiDi and we don't want that to prevent us from adding WebExtension testing support.

@OrKoN
Copy link
Contributor

OrKoN commented Dec 19, 2024

Is it for testing within WPT?

@xeenon
Copy link

xeenon commented Dec 19, 2024

@OrKoN Yes, see web-platform-tests/wpt#49786.

@OrKoN
Copy link
Contributor

OrKoN commented Dec 19, 2024

Thanks, the linked PR seems to be testing the WebDriver implementation defined by this PR. If the new endpoints are primarily meant to be used to test browser implementations of web extensions in WPT, testdriver.js allows implementing commands that match the WebDriver BiDi specification (the implementation can be vendor-specific and does not require WebDriver BiDi support).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants