-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xcm tool for NFTs #1798
xcm tool for NFTs #1798
Conversation
Thanks @anshulWeb3 for the application.
Thanks! |
Thankyou @keeganquigley for the review.
|
Thanks for the changes @anshulWeb3 it's looking better now. I will mark the application as ready for review and ping the committee members internally. In the meantime, a few additional questions:
|
Thankyou @keeganquigley for the questions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks @anshulWeb3 for clarifying. For the price, I'm willing to approve this PoC. Looking forward to see the result!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application. I have some questions:
- Are you aware of XCM V3 and it's support for NFT transfers?
- I assume that the biggest problem between different parchains and NFTs is standardization. How would you like to address this? What research/work has been done in regard to fungible assets that you could potentially leverage? Feel free to update the application accordingly.
Thanks @Noc2 for reviewing the application.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anshulWeb3 are you aware of this issue and this open PR that is related to that issue?
To enable derivative NFTs in the NFTs pallet, we should be able to represent a CollectionId as a MultiLocation.
It seems like some changes will have to be done to the NFT pallet, before XCM support can be implemented (cc @jsidorenko).
Hi @anshulWeb3, I think this discussion is also relevant for your tool. |
Thankyou for the review @takahser . |
Hi @vstam1 , |
@anshulWeb3 thanks for your feedback.
I agree that it's a good idea to wait for the relevant changes on the NFT pallet to be implemented, but I'd generally be happy to support this effort once that's done. I think it's advisable to have a look at the RFC that @vstam1 has shared in the comment above. Ideally, you'd get familiar with the changes that are currently being implemented and adapt your proposal accordingly. In the meanwhile I'm going to put this application on hold, but feel free to further update it. |
I have to mention that the RFC is a proposal for a new instruction for XCMv4. It can still take some time before we release v4. The planning now is Q4 2023. |
@vstam1 do you think it'd be possible to parallelise the development of XCMv4 and this proposal? Maybe, once the relevant part of the XCMv4 API is fixed the grantee team could start implementing this? |
Unfortunately we cannot. XCM is versioned, and we cannot add another instruction to version 3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anshulWeb3 I got the note from @vstam1 that they're going to move XCM into a separate repository to simplify the development process. Once the necessary changes have been implemented, you could technically start working on it, even before XCMv4 would be released. The downside of this approach is that the API might change until the release so you'd have to keep updating that dependency as you work on your code, to spot breaking changes early and avoid introducing breaking changes. This would allow you to accelerate the development and start earlier. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pinging me here. Given that's a level 1 grant, the application is already approved. But I'm happy to approve it as well and merge it.
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
Hi @anshulWeb3 did you want us to re-open the pull request? Are you still working on the milestone? |
Hi @keeganquigley we are currently looking for solutions which align with "not changing the Frame NFT pallet" approach. Apart from that we are waiting for the required changes to get uptream. |
Thanks @anshulWeb3 do you think these required changes will happen soon? |
Hi @anshulWeb3 do you plan on submitting a delivery soon? If not, please consider submitting an amendment to extend the timeline. Thanks! |
Hi @anshulWeb3 are you still working on this grant? I noticed there hasn't been much activity on the repos. Please let us know, otherwise after 2 weeks we will close the grant due to inactivity. |
Hi @keeganquigley . Sorry for the delayed response. I was on a Medical leave and the access to the account was with me only so any other team member was unable to respond in time. We've been engaged in research related to this matter and have explored various methods to access private fields such as ItemMetadataOf and CollectionMetadataOf within the FRAME NFT pallet, without altering the actual code. During this process, we've identified a solution and are currently in the implementation phase. We plan to provide you with a comprehensive update by next week. Thanks for your patience. |
Hi @keeganquigley . We have successfully reverted all modifications made to the FRAME NFT pallet, including changes to structs such as CollectionDetails, ItemDetails, CollectionMetadata, and ItemMetadata. These structs now align with the standard FRAME NFT pallet. |
Thanks for the update, @anshulWeb3. Sounds good to me. But could you submit an amendment to the grant application with an updated timeline? That makes it a lot easier for us to track project progress. |
Hi @keeganquigley , @semuelle We have successfully addressed the Runtime call challenge and are pleased to inform you that we will be delivering the xnft-pallet by the upcoming week. |
Hi @keeganquigley . The development is done and we are setting up the testing environment using Trappist. We expect to deliver by Wednesday. Thanks! |
Great @anshulWeb3 sounds good thanks for the update! |
Hello @keeganquigley . We are happy to announce that we have submitted the delivery of xNFT pallet. Looking forward to your response. Link to the PR. |
XCM tool for cross chain NFT
The Crosschain NFT Pallet is a unique initiative designed to facilitate the smooth movement of NFTs across various blockchain networks, utilizing the XCM protocol. Through the implementation of this pallet, individuals can effortlessly exchange NFTs between relay chains and parachains.
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)