Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwarmNL milestone 2 revision #2363

Merged
merged 5 commits into from
Oct 11, 2024
Merged

SwarmNL milestone 2 revision #2363

merged 5 commits into from
Oct 11, 2024

Conversation

sacha-l
Copy link
Contributor

@sacha-l sacha-l commented Aug 10, 2024

Project Abstract

This is a revision to Milestone 2 for building SwarmNl, previously stipulated here: #2201.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (Polkadot AssetHub (DOT, USDC & USDT) address in the application and bank details via email, if applicable).
  • I understand that an agreed upon percentage of each milestone will be paid in vested DOT, to the Polkadot address listed in the application.
  • I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @sacha-lansky:matrix.org

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Aug 10, 2024
@sacha-l sacha-l mentioned this pull request Aug 10, 2024
12 tasks
@keeganquigley keeganquigley added ready for review The project is ready to be reviewed by the committee members. amendment This PR proposes changes to an existing application. and removed admin-review This application requires a review from an admin. labels Aug 12, 2024
Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sacha-l I'd like to make a couple of points here.

  • the price of M2 is now 3x more expensive than in the original application. Please note that due to this price increase, this Level 2 grant would become a Level 3 grant, hence you'd need 5 approvals from members of the grants committee rather than 3.
  • On another note, I think the original weekly rate was $2k per FTE but now it's $2.4k, could you explain this price increase?
  • Regarding the significantly expanded scope (now requiring 2.5x the original FTE), I believe @keeganquigley would be the most qualified to assess whether all these additional deliverables are necessary and if the time estimate is realistic, given his prior evaluation of M1.

@sacha-l
Copy link
Contributor Author

sacha-l commented Aug 15, 2024

Thank you for taking the time to review @takahser.

The way we calculated things for Milestone 2 was indeed $2k per FTE, calculated at an hourly rate of $40 USD/hour at a 40 hour week. In this revision we have increased the hourly rate to $60 USD.

Upon completing Milestone 1, I realized we had significantly miscalculated the projected allocation of resources and cost. Namely:

  • I realized that the level of complexity and protocol development the work entails merits more than a $40 per hour salary. Just by looking at around at rates for similar work being anywhere between 80 and 120, feel the increase to 60 is a reasonable middle ground.
  • The single FTE was calculated to include both our hours, i.e. 10 hours of Project Management, writing tests, writing docs etc. + 30 hours dedicated to development. Both roles turned out to be equally important, each taking an equal amount of time, which turned out to be a lot more than 40 hour weeks. In my role for example I spent a lot more time writing code. Deji spent a lot of time on docs and guides. We basically became one unit. In this revision for Milestone 2, we are trying to be more realistic on the amount of effort we realize will be needed to deliver to the best of our abilities which is why we now have 1.5 FTE (putting my commitment at 20 hours a week and Deji's at 40 hours).
  • We realized the importance of research and testing and I hadn't anticipated this well. Our M1 delivery was projected on 6 weeks, but it actually took us 8. This is why in this revision we've allocated 2 weeks for research in M2.1; 2 weeks for review, testing and improvements in M2.2 + 2 more weeks for integration testing and benchmarking (which is tricky!) and 2 more weeks for testing and touching things up in the final deliverable, "Extendability of library". This is also why there's an increase in time

Overall, we adjusted the hourly rate to $60 and adjusted the projected workload to be more realistic based on the experience we had shipping M1. Hope this helps clarify.

@semuelle
Copy link
Member

Hi @sacha-l, thanks for clarifying. Since your initial application, we have started paying out grants with a percentage in DOT (vested over two years). Would you be comfortable with switching to 50% DOT going forward?

@sacha-l
Copy link
Contributor Author

sacha-l commented Aug 16, 2024

Hi @semuelle - can you provide more details on what that means ? What are the advantages of receiving DOT vested over two years?

@semuelle
Copy link
Member

It means, part of the payment is in DOT tokens and linearly unlocks over the span of two years. We have incorporated 50%+ vested DOT payments to incentivise grant recipients to participate in the ecosystem beyond the grant payout. See also https://wiki.polkadot.network/docs/learn-transactions#vested-transfers and https://grants.web3.foundation/docs/faq#what-does-it-mean-for-payments-to-be-at-least-50-dot.

In your case, if you choose 50% DOT, for M2, you would get 18,000 USD in fiat or stablecoin, and the remaining 18,000 USD as DOT, where each block on the network unlocks a small portion for two years.

@sacha-l
Copy link
Contributor Author

sacha-l commented Aug 17, 2024

Hi @semuelle - After carefully considering the locked DOT payment opportunity, we decided we would happily accept switching to this model going forward.

@thewoodfish
Copy link

Hi @semuelle - After carefully considering the locked DOT payment opportunity, we decided we would happily accept switching to this model going forward.

It means, part of the payment is in DOT tokens and linearly unlocks over the span of two years. We have incorporated 50%+ vested DOT payments to incentivise grant recipients to participate in the ecosystem beyond the grant payout. See also https://wiki.polkadot.network/docs/learn-transactions#vested-transfers and https://grants.web3.foundation/docs/faq#what-does-it-mean-for-payments-to-be-at-least-50-dot.

In your case, if you choose 50% DOT, for M2, you would get 18,000 USD in fiat or stablecoin, and the remaining 18,000 USD as DOT, where each block on the network unlocks a small portion for two years.

Thank you @semuelle , we think this is a great model that works. It will also help us further build and test our next project easily on the Polkadot network which we absolutely intend to do, in great style.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Since @semuelle is currently OOO, let me quickly reply: In this case, could you add a relay chain address to the document? As far as I remember, you can only stake locked DOTs on the relay chain. Other than that, would you still be willing to reduce the price? Other committee members raised concerns about the significant increase.

@sacha-l
Copy link
Contributor Author

sacha-l commented Sep 4, 2024

Thanks for your reply @Noc2. We would be happy to discount our hours for this milestone push by 20%, which would bring the total cost to $28,800.00. With this we would request that we get the amount in USDC instead of locked DOT. Would that work on your end?

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here. At this stage, we need to follow the new rule: "At least 50% of any grant is paid out in vested DOT." and can not easily accept application that don't take vested DOTs.

@sacha-l
Copy link
Contributor Author

sacha-l commented Sep 11, 2024

Sorry for the delay here. At this stage, we need to follow the new rule: "At least 50% of any grant is paid out in vested DOT." and can not easily accept application that don't take vested DOTs.

Understood. We would be happy to stick to the original plan and get more reviews from the committee in that case. If for some reason you advise against this, I would like to understand what the committee's reasoning might be. If this might be the case and because we just really want to get to work on shipping milestone 2, we would reduce some of the scope to keep it within the 30k tier.

@thewoodfish
Copy link

Thank you very much @sacha-l, we patiently await your feedback @Noc2. Thank you.

@keeganquigley
Copy link
Contributor

keeganquigley commented Sep 18, 2024

Thanks @sacha-l just to confirm, you want to use the same Polkadot address for both USDC & DOT payments?

@sacha-l
Copy link
Contributor Author

sacha-l commented Sep 19, 2024

Thanks @sacha-l just to confirm, you want to use the same Polkadot address for both USDC & DOT payments?

Yes we will use the same address for locked DOT payments and USDC. But we will use a different address than the last milestone payment. The address will be: 14pG7HieCjNk2hZ4X2YvxkbpAXs9oCeW8aNZcD7tD2tpaJT9

Has the committee come to a conclusion ?

@keeganquigley
Copy link
Contributor

Thanks @sacha-l in that case, could you please update the Polkadot address at the top of the application as part of this commit? Since the address in the application has to match the one on the invoice. After that I'm willing to approve it myself, and then I can ping the other committee members again.

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Sep 19, 2024
@sacha-l
Copy link
Contributor Author

sacha-l commented Sep 19, 2024

Thank you for your time. I have updated the address in the latest commit.

@keeganquigley
Copy link
Contributor

Thanks @sacha-l can you also change the level from 2 to 3? Sorry I should have mentioned that also.

@keeganquigley keeganquigley removed the admin-review This application requires a review from an admin. label Sep 19, 2024
@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Sep 20, 2024
keeganquigley
keeganquigley previously approved these changes Sep 20, 2024
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @sacha-l I'm willing to approve, and will ping the rest of the team again to take a look.

@keeganquigley keeganquigley removed the admin-review This application requires a review from an admin. label Sep 20, 2024
@takahser takahser self-requested a review September 24, 2024 01:19
@takahser takahser self-assigned this Sep 24, 2024
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sacha-l, I'm with David in that we should convert the remaining milestone to a 50% DOT payment. Alternatively, if the total remains under 30k I'd be willing to keep it as USDC/USDT payment, but that means the milestone would be capped at 18k USD.

@sacha-l
Copy link
Contributor Author

sacha-l commented Sep 25, 2024

Hi @semuelle thanks for you comment. To clarify, we would be happy to go forward with the original plan and accept locked DOT.

@semuelle
Copy link
Member

Hi @semuelle thanks for you comment. To clarify, we would be happy to go forward with the original plan and accept locked DOT.

Great to hear. In that case, could you please add a DOT %: 50% (or more) under the Costs line?

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Sep 27, 2024
@keeganquigley keeganquigley removed the admin-review This application requires a review from an admin. label Sep 27, 2024
keeganquigley
keeganquigley previously approved these changes Sep 27, 2024
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@thewoodfish
Copy link

thewoodfish commented Oct 1, 2024

Hi @semuelle thanks for you comment. To clarify, we would be happy to go forward with the original plan and accept locked DOT.

Great to hear. In that case, could you please add a DOT %: 50% (or more) under the Costs line?

Hello @semuelle, we have made the changes requested. We look forward to your response. Thank you

Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update on this?

- **Costs:** $12,000
- **Estimated Duration:** 2.5 months (10 weeks)
- **FTE:** 1.5
- **Costs:** $36,000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The total cost is $36k, but the sum of costs for M1+M2 is $12k+$36k=$48k
Which number is wrong here? Could you fix this accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M1 has been paid already. 36k is for M2. Does this clarify?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The application doc should reflect the costs of each milestone, as well as the total cost correctly. The fact that M1 has been paid already doesn't have an impact on this. Could you please rectify the amounts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah understood now, updated in 5b524d4

@thewoodfish
Copy link

@takahser @semuelle @Noc2 we have gone ahead to make all the changes you requested.
We anticipate your approval. Thank you very much.

@takahser
Copy link
Collaborator

takahser commented Oct 8, 2024

@thewoodfish thx for the reminder. I just commented.

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Oct 8, 2024
@thewoodfish
Copy link

@thewoodfish thx for the reminder. I just commented.

Always a pleasure ser! @sacha-l has made the change. I look forward to your response. Thank you!

@keeganquigley keeganquigley removed the admin-review This application requires a review from an admin. label Oct 8, 2024
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thewoodfish
Copy link

Thank you very much @semuelle and @Noc2. We patiently await your approval @takahser. Thank you.

@semuelle semuelle merged commit 2b078d4 into w3f:master Oct 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants