-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create alphaday.md #2394
Create alphaday.md #2394
Conversation
Hello @keeganquigley, I have reopened this pull request since we have now fully open sourced Alphaday here: https://github.com/AlphadayHQ/alphaday I request that you please reconsider the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mikael337 happy to reconsider. I have a few initial comments:
- The grants program focuses mainly on the technical implementation, so while we can fund the development itself, we can't fund things like Youtube stream containing educational Polkadot/Kusama/Web3 content or the podcast. Could you please remove these from the deliverables?
- The mandatory deliverables 0a. - 0d. are missing. Can you please add these as shown in the application template?
Hello @keeganquigley, I've updated the file with the newly requested changes. |
| Number | Deliverable | Specification | | ||
| -----: | ----------- | ------------- | | ||
| 0a. | License | MIT | | ||
| 0b. | Documentation | Not applicable to Alphaday, as we have no Substrates nodes or sending functionality on the app | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation is always required for development milestones, regardless of the tech stack. At the very least a GH readme, but it's nice to see user-facing documentation as well, for front-end deliverables.
| -----: | ----------- | ------------- | | ||
| 0a. | License | MIT | | ||
| 0b. | Documentation | Not applicable to Alphaday, as we have no Substrates nodes or sending functionality on the app | | ||
| 0c. | Testing Guide | We can provide a document as a guide to give a bit more detail on how to test a completed dashboard's functionality. It will be a reference to the points listed below (1-14) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We require unit tests as well, at least for the Python-Django backend. (But it's also nice to see Cypress tests or something similar for React front-ends). Would you be willing to include these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my above comments, we also require mockups for the front-end if you could include those too. Thanks!
Hello @keeganquigley , Thank you for the feedback. I spoke to the devs in our team and we are not able to provide:
The reasons varied. I have gone ahead and removed the Docker file from the milestones and changed the duration of Milestone 2 to 2 months, as per your request. Please let me know if we can still proceed without providing the 3 listed points above, or if there is a workaround somehow. |
Thanks for your response @Mikael337, and for talking with your team. I know this grant is rather small, so it makes sense to be small in scope. Therefore I understand it might not have certain components. Unfortunately, the above-mentioned deliverables are mandatory, so it would be unfair to other projects if we were to accept this one without them. The lack of mockups is the one item that could probably be forgiven at the current price. However, the lack of unit tests perplexes me because all code should generally be tested, with perhaps one exception for code written at a hackathon. Documentation is also something we have to have, otherwise how would we know how to run and test it? Therefore, I personally won't approve the application; however, I will mark it as ready for review in case other committee members disagree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you unable to provide unit tests? Any decent open source project should have thorough testing where applicable. If not, I don't think we should support it.
@Mikael337 I will go ahead and close this application due to the reasons noted above. If you are planning on addressing these concerns, please let me know and I will re-open it. |
Project Abstract
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)