Issue1211 MM window definition in part 5 #1213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1211 => Fixes definition of MM windows in g.part5.definedays as it assumed fixed window duration of 24 hours which does not hold true in daylight saving time days.
Checklist before merging:
inst/NEWS.Rd
with a user-readable summary. Please, include references to relevant issues or PR discussions.DESCRIPTION
file, if you think you made a significant contribution.If NEW GGIR parameter(s) were added then these NEW parameter(s) are:
man/GGIR.Rd
R/load_params.R
R/check_params.R
vignettes/GGIRParameters.Rmd
with references to the GGIR parts the parameter is used in.If GGIR parameter(s) were deprecated these parameter(s) are:
man/GGIR.Rd
R/load_params.R
R/check_params.R
vignettes/GGIRParameters.Rmd
R/extract_params.R
with deprecated parameters such that these do not produce warnings when found in old config.csv files.