Add dynamic key binding references to help text #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new test method 'RunAsync_HelpCommand_ShowsPassedKeyBindings' has been added to the ReadEvalPrintLoopTests.cs.
Introduced a new class 'KeyExtensions' that provides static methods to convert key patterns and console modifiers into their string representations.
The help text in the REPL has been updated to dynamically display the key bindings configured by the user.
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
=======================================
- Coverage 77.4% 77.3% -0.1%
=======================================
Files 82 83 +1
Lines 5545 5564 +19
Branches 729 731 +2
=======================================
+ Hits 4293 4304 +11
- Misses 985 992 +7
- Partials 267 268 +1
|
|
I've done a quick review and this looks great! I'll pull this down tomorrow and do some testing, then merge it if it all looks good. Thanks for your contribution! I appreciate the high quality code and unit tests. |
|
Thanks again! Testing all went well. |
|
Credited you in the Contributors List. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dynamic key binding references to help text
The help text in the REPL has been updated to dynamically display the key bindings configured by the user.
Fix for #124