Fix multithreading issue in ConsoleNugetLogger #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
=====================================
Coverage 77.4% 77.4%
=====================================
Files 83 83
Lines 5583 5596 +13
Branches 736 735 -1
=====================================
+ Hits 4323 4336 +13
Misses 992 992
Partials 268 268 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some locking to prevent multithreading-related errors in ConsoleNugetLogger.
There could be some more interesting ways of solving this (e.g. immutable collections, or concurrent collections with snapshotting), but let's just try some good ol' fashioned locking first.
Fixes #311. Note that the nuget package mentioned in that issue doesn't actually appear to be installable in .NET 8 (I believe it's an issue with the package, as opposed to an issue with CSharpRepl). But this PR fixes the exception mentioned in that issue.