Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions from Roslyn Completion API #334

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

waf
Copy link
Owner

@waf waf commented Feb 24, 2024

Workaround for #331. We get the following errors from the roslyn completion libs:

InvalidOperationException: This program location is thought to be unreachable. File='/_/src/Features/CSharp/Portable/Completion/CompletionProviders/PropertySubPatternCompletionProvider.cs' Line=116

If we get any roslyn library exceptions during autocompletion, it's better to just not have any completions than crash the entire repl.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 77.6%. Comparing base (9eff460) to head (55ce52a).
Report is 3 commits behind head on main.

Files Patch % Lines
...arpRepl.Services/Completion/AutoCompleteService.cs 64.2% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #334     +/-   ##
=======================================
- Coverage   77.6%   77.6%   -0.1%     
=======================================
  Files         83      83             
  Lines       5597    5600      +3     
  Branches     734     730      -4     
=======================================
+ Hits        4346    4347      +1     
- Misses       984     986      +2     
  Partials     267     267             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waf waf merged commit 51230d1 into main Feb 25, 2024
3 checks passed
@waf waf deleted the handle-exceptions-in-roslyn-completion-api branch February 25, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant