[v3] Correct detection of npm with acceptable version (#3458)

* Correct detection of npm with acceptable version * Update changelog
wailsapp · May 5, 2024 · 0833a6d · 0833a6d
1 parent 7d851d8
commit 0833a6d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/mkdocs-website/docs/en/changelog.md b/mkdocs-website/docs/en/changelog.md
@@ -64,6 +64,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fix registering events causing a nil map assignment by [@hfoxy](https://github.com/hfoxy) in [#3426](https://github.com/wailsapp/wails/pull/3426)
 - Fix unmarshaling of bound method parameters by [@fbbdev](https://github.com/fbbdev) in [#3431](https://github.com/wailsapp/wails/pull/3431)
 - Fix handling of multiple return values from bound methods by [@fbbdev](https://github.com/fbbdev) in [#3431](https://github.com/wailsapp/wails/pull/3431)
+- Fix doctor detection of npm that is not installed with system package manager by [@pekim](https://github.com/pekim) in [#3458](https://github.com/wailsapp/wails/pull/3458)
 
 ### Changed
 

diff --git a/v3/internal/doctor/doctor_common.go b/v3/internal/doctor/doctor_common.go
@@ -23,6 +23,8 @@ func checkCommonDependencies(result map[string]string, ok *bool) {
 			if major < 7 {
 				*ok = false
 				npmVersion = append(npmVersion, []byte(". Installed, but requires npm >= 7.0.0")...)
+			} else {
+				*ok = true
 			}
 		}
 	}