Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Wails3 Doctor recognize globally installed apt packages #2972

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

atterpac
Copy link
Member

Description

wails3 doctor command failed to recognize installed apt due to checking for "[installed]" so any packages installed both globally and locally packages are listed as "all" for example a globally installed npm would return npm/jammy 8.5.1~ds-1 all

Fixes if packages have more than one attribute "[installed, <other attributes>]" by checking if apt list -qq returns either "installed" or "any"

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Linux (Ubuntu)

Test Configuration

Removed required packages pkg-config and libwebkit to ensure the test still fails if no package is missing
Added removed packages per wails doctor instructions
Ran wails3 doctor to ensure it validated the install

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR (no changed needed)
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (no changes needed)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (existing tests pass)
  • New and existing unit tests pass locally with my changes

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for dapper-pastelito-9b5e5b ready!

Name Link
🔨 Latest commit 9e35210
🔍 Latest deploy log https://app.netlify.com/sites/dapper-pastelito-9b5e5b/deploys/6533626e76928a0008eea7c5
😎 Deploy Preview https://deploy-preview-2972--dapper-pastelito-9b5e5b.netlify.app/changelog
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Adding a space to ensure checking against "all" doesn't always catch "install" or "not-installed" etc
Doctor Apt Verify
@leaanthony leaanthony merged commit fb17ec8 into wailsapp:v3-alpha Oct 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants