Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Bump x/tools to 0.17.0 to fix compatiblity with go 1.22 #3244

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Feb 8, 2024

Fixes #3242

Summary by CodeRabbit

  • Bug Fixes
    • Fixed compatibility issues with the Wails CLI for Go version 1.22 and later.

@stffabi stffabi requested a review from leaanthony February 8, 2024 06:57
Copy link
Contributor

coderabbitai bot commented Feb 8, 2024

Walkthrough

The overall change addresses a specific compatibility issue where the Wails CLI would encounter a panic when built with Go 1.22 and later versions, particularly on Windows. The fix ensures that projects using Wails can now be built successfully without runtime errors, enhancing the stability and reliability of the build process.

Changes

File Path Change Summary
website/src/pages/.../changelog.mdx Fixed compatibility for the Wails CLI with Go 1.22+.

Assessment against linked issues

Objective Addressed Explanation
Resolve panic when building with Go 1.22 and Wails v2.7.1 on Windows (#3242)
Identify and resolve the bug causing the panic in the Wails library, ensuring application stability (#3224) The change mentions compatibility with Go 1.22 but does not detail if the specific panic in libraries like go-webview2 and wails is directly addressed.
Address the compilation failure with wails build -compiler due to Go version discrepancies (#3120) The provided summary does not indicate changes related to the -compiler flag or Go version discrepancies in the build process.

Related issues

Poem

In the world of code, where bugs often hop,
A rabbit worked hard, with a skip and a pop.
🐾🛠️ With Go 1.22, it fixed a great plight,
"No more panics," it said, "on this bright night!"

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 72e12ef and 1ca7eda.
Files ignored due to path filters (2)
  • v2/go.mod is excluded by: !**/*.mod
  • v2/go.sum is excluded by: !**/*.sum
Files selected for processing (1)
  • website/src/pages/changelog.mdx (1 hunks)

@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed `-compiler` flag for `wails build`, `wails dev` and `wails generate module`. Fixed in [PR](https://github.com/wailsapp/wails/pull/3121) by [@xtrafrancyz](https://github.com/xtrafrancyz)
- Fixed uninitialized `SecondInstanceData.WorkingDirectory` on linux and windows ([#3154](https://github.com/wailsapp/wails/pull/3154)).
- Fixed save file dialog not appending file extension automatically on Windows by @almas1992 in [PR](https://github.com/wailsapp/wails/pull/3205)
- Fixed compatibility for wails cli being built with go 1.22 and later. Fixed by @stffabi in [PR](https://github.com/wailsapp/wails/pull/3244)
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry for the compatibility fix with Go 1.22 should include the PR number for traceability.

- Fixed compatibility for wails cli being built with go 1.22 and later. Fixed by @stffabi
+ Fixed compatibility for wails cli being built with go 1.22 and later. Fixed by @stffabi in [PR](https://github.com/wailsapp/wails/pull/3244)

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- Fixed compatibility for wails cli being built with go 1.22 and later. Fixed by @stffabi in [PR](https://github.com/wailsapp/wails/pull/3244)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is linked in the changelog and this is in line with all other changelog entries and the guidelines of the Wails project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stffabi: Acknowledged. Thank you for the clarification.

Copy link

cloudflare-workers-and-pages bot commented Feb 8, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ca7eda
Status: ✅  Deploy successful!
Preview URL: https://629b17bb.wails.pages.dev
Branch Preview URL: https://bugfix-go-1-22-compat.wails.pages.dev

View logs

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing find! 🙏

@leaanthony leaanthony merged commit e29b375 into master Feb 8, 2024
59 of 60 checks passed
@leaanthony leaanthony deleted the bugfix/go-1.22-compat branch February 8, 2024 11:40
atterpac pushed a commit to atterpac/wails that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic when building with go 1.22 and wails 2.7.1 on Windows
2 participants