-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Export Window.UnFullscreen method from JS runtime module #3280
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
To avoid further conflicts, I am gonna wait to bring this up to date until #3279 is either merged or closed |
Here too it is necessary to run |
I am closing this as it is superseded by #3295 |
Description
The Window.UnFullscreen method is available to the JS runtime, but is not exported. This patch fixes the problem.
The newly introduced
window-api
example (same as PR #3279) allows reproducing the problem and testing after the change: before the change, clicking the UnFullscreen button results in a JS exception being thrown.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I run the
window-api
example after the change and verified that the UnFullscreen button works as intended.Test Configuration
Checklist:
mkdocs-website/docs/en/changelog.md
with details of this PR