[V3] Linux Drag n Drop

[atterpac]

Description

Adjusts the linux drag and drop to function as expected and up to par with the examples wails provides

Fixes # (issue)
Linux drag and drop not working

Type of change

• [ X ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Would appreciate additional testing, works in Ubuntu 22.04 without a window manager but when used inside bswpm it was giving issues hanging after a file was dropped this could be on the window manager end.

• [ X ] Linux

Test Configuration

# System
┌───────────────────────────────────────────────────┐
| Name         | Ubuntu                             |
| Version      | 22.04                              |
| ID           | ubuntu                             |
| Branding     | 22.04.3 LTS (Jammy Jellyfish)      |
| Platform     | linux                              |
| Architecture | amd64                              |
| CPU          | AMD Ryzen 7 3700X 8-Core Processor |
| GPU 1        | Unknown                            |
| Memory       | 12GB                               |
└───────────────────────────────────────────────────┘

# Build Environment
┌─────────────────────────────────────────────────────────┐
| Wails CLI    | v3.0.0-alpha.4                           |
| Go Version   | go1.22.0                                 |
| Revision     | 472af46380c199b1db338579a20191033c939505 |
| Modified     | true                                     |
| -buildmode   | exe                                      |
| -compiler    | gc                                       |
| CGO_CFLAGS   |                                          |
| CGO_CPPFLAGS |                                          |
| CGO_CXXFLAGS |                                          |
| CGO_ENABLED  | 1                                        |
| CGO_LDFLAGS  |                                          |
| GOAMD64      | v1                                       |
| GOARCH       | amd64                                    |
| GOOS         | linux                                    |
| vcs          | git                                      |
| vcs.modified | true                                     |
| vcs.revision | 472af46380c199b1db338579a20191033c939505 |
| vcs.time     | 2024-04-13T02:46:01Z                     |
└─────────────────────────────────────────────────────────┘

# Dependencies
┌──────────────────────────────────────┐
| npm        | 10.5.0                  |
| pkg-config | 0.29.2-1ubuntu3         |
| gcc        | 12.9ubuntu3             |
| libgtk-3   | 3.24.33-1ubuntu2        |
| libwebkit  | 2.42.5-0ubuntu0.22.04.2 |
└────── * - Optional Dependency ───────┘

Checklist:

• I have updated website/src/pages/changelog.mdx with details of this PR

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tmclane]

How does this fix anything?

There are no functional changes other than argument type changes that I see.
Was a commit left out?

[tmclane]

Is this supposed to be doing the same thing for as this PR?

#3346

[atterpac]

I was getting errors that C.onDragNDrop in the C.g_signal_connect register wasn't the correct parameter typing for the GtkWidget::drag-data-received signal
Not sure why, V3-alpha branch doesn't work but with this branch it does.

[atterpac]

Is this supposed to be doing the same thing for as this PR?

#3346

Appears so didn't see that one get opened this week

[tmclane]

Fair enough.

I wonder why it works for me on Manjaro. Guess it's not as particular.

[tmclane]

Will get this and the other one in as well.
Either way this will be resolved I think.

[leaanthony]

Thanks for taking the time to do this @atterpac 🙏

[tmclane]

@atterpac Would you please test against v3-alpha again with the other PR merged please?
I believe this is addressed so I am closing this PR.

[atterpac]

@atterpac Would you please test against v3-alpha again with the other PR merged please? I believe this is addressed so I am closing this PR.

Works for me thanks!