Add hostname option to extension #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandarez
approved these changes
Mar 15, 2023
|
This config will be synchronized by Chrome if logged in the same Google account. How to set this config for each device? |
alanhamlett
changed the title
alanhamlett
changed the title
|
I'm not sure, why would you want different configs on different machines? |
I have two machines and I want to separate them in the machines stats instead of "Unknown Hostname". 
|
|
Oh sorry, got it. We should prevent that hostname option from syncing between browsers. |
|
Created #243 for this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-PR Checklist
npm testlocally and there are no warnings or errors, from lint or testSummary
#87
Adds the possibility to users to set up
hostnameon the options of the extension/addon and avoid seeingUnknown hostnamein reports