feat: add button to query from store in light-js #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adklempner
force-pushed
the
adklempner/light-js-store-query
branch
from
743a644 to
304b31b
Compare
adklempner
force-pushed
the
adklempner/light-js-store-query
branch
2 times, most recently
from
9ec4bdb to
3a7da56
Compare
weboko
reviewed
Nov 3, 2023
examples/light-js/index.html
Outdated
| let messages = []; | ||
| // Each key in messages should be string hash. each value is an obj of class Message | ||
| let messages = {}; | ||
| class Message { |
There was a problem hiding this comment.
seems cumbersome - you can just store object { text, timestamp } and make a string during rendering
There was a problem hiding this comment.
Removed class Message and replaced with a regular object
adklempner
force-pushed
the
adklempner/light-js-store-query
branch
from
3a7da56 to
f78d4f9
Compare
adklempner
force-pushed
the
adklempner/light-js-store-query
branch
from
f78d4f9 to
e4f4f56
Compare
fryorcraken
approved these changes
Nov 6, 2023
| @@ -91,12 +100,19 @@ <h2>Remote Peers</h2> | |||
| const ContentTopic = "/js-waku-examples/1/chat/utf8"; | |||
| const decoder = createDecoder(ContentTopic); | |||
| const encoder = createEncoder({ contentTopic: ContentTopic }); | |||
| let messages = []; | |||
| // Each key is a unique identifier for the message. Each value is an obj { text, timestamp } | |||
| let messages = {}; | |||
There was a problem hiding this comment.
using a Map might makes your life easier in terms of iterating through.
danisharora099
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be merged after #282
fulfills part of #248