fix: empty responses should not generate an error

waku-org · Jan 23, 2023 · 29a6c15 · 29a6c15
1 parent e0ccdbe
commit 29a6c15
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/waku/v2/protocol/store/waku_store_client.go b/waku/v2/protocol/store/waku_store_client.go
@@ -206,9 +206,10 @@ func (store *WakuStore) queryFrom(ctx context.Context, q *pb.HistoryQuery, selec
 	}
 
 	if historyResponseRPC.Response == nil {
-		logger.Error("empty response")
-		metrics.RecordStoreError(store.ctx, "emptyRpcResponseFailure")
-		return nil, ErrEmptyResponse
+		// Empty response
+		return &pb.HistoryResponse{
+			PagingInfo: &pb.PagingInfo{},
+		}, nil
 	}
 
 	metrics.RecordMessage(ctx, "retrieved", len(historyResponseRPC.Response.Messages))

diff --git a/waku/v2/protocol/store/waku_store_common.go b/waku/v2/protocol/store/waku_store_common.go
@@ -41,8 +41,6 @@ var (
 	ErrFailedQuery = errors.New("failed to resolve the query")
 
 	ErrFutureMessage = errors.New("message timestamp in the future")
-
-	ErrEmptyResponse = errors.New("empty store response")
 )
 
 type WakuSwap interface {