chore: refactor sender api #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaichaosun
force-pushed
the
send-wrapper
branch
from
3a98af0
to
4f027dd
Compare
kaichaosun
requested review from
richard-ramos and
chaitanyaprem
as code owners
|
Fixed the comments, also add an interface ISentCheck for MessageSentCheck, we can probably add interfaces to relay and lightpush for easily mock tests in future. How do you think about it? @richard-ramos @chaitanyaprem |
kaichaosun
force-pushed
the
send-wrapper
branch
from
f3d854c
to
5ae7195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1181
API usage in status-go: status-im/status-go#5676