feat: shard aware pruning of peer store #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyaprem
force-pushed
the
feat/shard-aware-pruning
branch
from
e482044
to
62dea88
Compare
chaitanyaprem
force-pushed
the
feat/shard-aware-pruning
branch
from
62dea88
to
12711bd
Compare
kaichaosun
reviewed
Aug 15, 2024
kaichaosun
approved these changes
Aug 15, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Peer store is not being pruned in go-waku rather new peer addition was being blocked once capacity is hit. This would cause issues once community sharding would be implemented.
Replicating changes made in nwaku waku-org/nwaku#2167 to address this. Since algorithm is tested in nwaku, not adding any specific tests.
Please do thorough review 🙏
Changes
closes #925