ci: use GIT_REF for building docker image when set #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
requested review from
richard-ramos and
chaitanyaprem
as code owners
chaitanyaprem
approved these changes
Sep 11, 2024
jakubgs
reviewed
Sep 11, 2024
There was a problem hiding this comment.
This is wrong. GIT_REF is used to specify what version should be built, GIT_COMMIT is the variable set by Jenkins based on what has been actually checked out:
GIT_COMMIT - The commit hash being checked out.
https://ci.status.im/env-vars.html/
You should not use GIT_REF for at least two reasons:
- It can be anything: branch, tag, or a commit.
- It might not be set at all if build source version is hardcoded.
You will need to undo or revert this commit.
siddarthkay
added a commit
that referenced
this pull request
Sep 11, 2024
This reverts commit 1a96cd2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the build stage which builds the Docker Image to use
GIT_REFwhen its set.This ensures that when we perform a parameterised build from Jenkins we actually get a docker image from the branch or commit we set in
GIT_REF