feat: ratelimit store queries and add options to Next #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
force-pushed
the
ratelimit-store
branch
from
fd652cd
to
2dfbdba
Compare
chaitanyaprem
approved these changes
Sep 18, 2024
richard-ramos
force-pushed
the
ratelimit-store
branch
from
8b859c7
to
e94eaa0
Compare
richard-ramos
force-pushed
the
ratelimit-store
branch
from
e94eaa0
to
95676e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the refactoring for the storenode cycle. This will rate limit the store queries to a max of 8 queries per second per peerID. (This is the value used in staging). It's possible to skip this rate limit via options.
In addition to that while debugging an issue with the storenode message counter, i found that not being able to pass options to
Nextto be somewhat limiting, specially if you want to change the requestID to some deterministic value, hence i modified it to pass options.