refactor: use protobuffer for API storenode queries #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (1)
|
kaichaosun
approved these changes
Oct 23, 2024
plopezlpz
approved these changes
Oct 23, 2024
| @@ -0,0 +1,12 @@ | |||
| package common | |||
There was a problem hiding this comment.
can you make the file snake case? storenode_requestor.go?
chaitanyaprem
approved these changes
Oct 23, 2024
|
|
||
| var params Parameters | ||
| params.selectedPeer = peerID | ||
| if params.selectedPeer == "" { |
There was a problem hiding this comment.
I am guessing peer-selection would be added later.
There was a problem hiding this comment.
Yes. I want to get the store queries to work first as they do now, with nwaku
richard-ramos
force-pushed
the
master
branch
3 times, most recently
from
c6c6479
to
6bdf125
Compare
richard-ramos
force-pushed
the
feat/gen-query
branch
from
212f697
to
7b2ac04
Compare
richard-ramos
force-pushed
the
feat/gen-query
branch
from
7b2ac04
to
b6fac0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow more flexibility at the moment of doing queries, instead of having custom functions that receive N different combination of parameters to do a store query, we use instead a single function which receives instead a StoreQueryRequest protobuffer
The json representation of the StoreQueryRequest matches what is used in libwaku, and since protobuffers in nwaku and go-waku are the same (and are supposed to be backward compatible), we can safely use them. It has the side effect of making the API simpler too
cc: @gabrielmer, @Ivansete-status