Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log output and encoding #656

Merged
merged 1 commit into from
Aug 19, 2023
Merged

fix: log output and encoding #656

merged 1 commit into from
Aug 19, 2023

Conversation

richard-ramos
Copy link
Member

Description

Adds back code that I deleted by mistake in 61cba07#diff-1365cc75829d0357d9c3adbd9fbc213f47e9ad86aa02e9e24f1513d84e7de037L109

Issue

closes #649

@status-im-auto
Copy link

status-im-auto commented Aug 18, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 37d0605 #1 2023-08-18 22:21:03 ~1 min linux 📦deb
✔️ 37d0605 #1 2023-08-18 22:22:17 ~2 min nix-flake 📄log
✔️ 37d0605 #1 2023-08-18 22:22:47 ~2 min tests 📄log
✔️ 37d0605 #1 2023-08-18 22:23:04 ~3 min tests 📄log
✔️ 37d0605 #1 2023-08-18 22:23:32 ~3 min android 📦tgz
✔️ 37d0605 #1 2023-08-18 22:24:52 ~4 min ios 📦tgz

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaitanyaprem chaitanyaprem merged commit ee17c23 into master Aug 19, 2023
3 checks passed
@chaitanyaprem chaitanyaprem deleted the log-output branch August 19, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: CLI flag for log-output is not working with file as option
3 participants