Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln): run rln in all relay pubsubtopics + remove cli flags #663

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Aug 21, 2023

Changes

  • Remove --rln-relay-pubsub-topic and --rln-relay-content-topic cli flags.
  • Remove all references to pubsub and content topics in rln
  • Decouples relay from RLN relay, by creating a Validator function that should be called to configure a default validator
  • Splits mountRlnRelay() into setupRlnRelay() and startRlnRelay()
  • Update test units
  • Verify service node and chat2 work as expected

Issue

part of #655

@status-im-auto
Copy link

status-im-auto commented Aug 21, 2023

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ eb130c1 #1 2023-08-21 20:59:29 ~1 min linux 📦deb
✔️ eb130c1 #1 2023-08-21 21:00:05 ~1 min nix-flake 📄log
✖️ eb130c1 #1 2023-08-21 21:00:16 ~2 min tests 📄log
✔️ eb130c1 #1 2023-08-21 21:01:12 ~3 min tests 📄log
✔️ eb130c1 #1 2023-08-21 21:02:00 ~3 min android 📦tgz
✔️ eb130c1 #1 2023-08-21 21:02:53 ~4 min ios 📦tgz
✔️ 08f86b5 #2 2023-08-22 17:21:33 ~1 min linux 📦deb
✔️ 08f86b5 #2 2023-08-22 17:22:38 ~2 min nix-flake 📄log
✔️ 08f86b5 #2 2023-08-22 17:23:18 ~2 min tests 📄log
✔️ 08f86b5 #2 2023-08-22 17:23:36 ~3 min tests 📄log
✔️ 08f86b5 #2 2023-08-22 17:23:58 ~3 min android 📦tgz
✔️ 08f86b5 #2 2023-08-22 17:24:42 ~4 min ios 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3c1e52c #3 2023-08-24 14:27:28 ~1 min linux 📦deb
✔️ 3c1e52c #3 2023-08-24 14:28:16 ~1 min tests 📄log
✔️ 3c1e52c #3 2023-08-24 14:29:22 ~3 min tests 📄log
✔️ 3c1e52c #3 2023-08-24 14:30:14 ~4 min nix-flake 📄log
✔️ 3c1e52c #3 2023-08-24 14:30:21 ~4 min ios 📦tgz
✔️ 3c1e52c #3 2023-08-24 14:32:03 ~5 min android 📦tgz
✔️ 3c1e52c #4 2023-08-24 14:38:33 ~19 sec nix-flake 📄log
✔️ 3c1e52c #4 2023-08-24 14:38:42 ~28 sec linux 📦deb
✔️ 3c1e52c #4 2023-08-24 14:39:08 ~53 sec tests 📄log
✔️ 3c1e52c #4 2023-08-24 14:41:05 ~2 min tests 📄log
✔️ 3c1e52c #4 2023-08-24 14:41:12 ~3 min android 📦tgz
✔️ 3c1e52c #4 2023-08-24 14:42:07 ~3 min ios 📦tgz
✔️ 431fcff #5 2023-08-24 14:44:13 ~34 sec linux 📦deb
✔️ 431fcff #5 2023-08-24 14:45:03 ~1 min tests 📄log
✔️ 431fcff #5 2023-08-24 14:45:47 ~2 min tests 📄log
✔️ 431fcff #5 2023-08-24 14:45:47 ~2 min nix-flake 📄log
✔️ 431fcff #5 2023-08-24 14:46:47 ~3 min android 📦tgz
✔️ 431fcff #5 2023-08-24 14:47:17 ~3 min ios 📦tgz

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chaitanyaprem

This comment was marked as duplicate.

@richard-ramos richard-ramos force-pushed the rln-subcommand branch 2 times, most recently from 060bcbc to 93398ed Compare August 24, 2023 14:33
Base automatically changed from rln-subcommand to master August 24, 2023 14:37
@richard-ramos richard-ramos merged commit ddb08ad into master Aug 24, 2023
1 check passed
@richard-ramos richard-ramos deleted the rln-by-default branch August 24, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants