feat: rln metrics #666
Merged
feat: rln metrics #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (42)
|
richard-ramos
force-pushed
the
rln-metrics
branch
from
927cdb3
to
f6c202f
Compare
richard-ramos
force-pushed
the
rln-metrics
branch
from
f6c202f
to
c33459f
Compare
richard-ramos
force-pushed
the
rln-metrics
branch
3 times, most recently
from
07fc6b5
to
8412bca
Compare
chaitanyaprem
approved these changes
Aug 24, 2023
waku/v2/protocol/rln/metrics.go
Outdated
| }) | ||
|
|
||
| var proofVerificationDurationSeconds = prometheus.NewGauge( | ||
| prometheus.GaugeOpts{ |
There was a problem hiding this comment.
Shouldn't this be a histogram?
richard-ramos
force-pushed
the
rln-by-default
branch
from
3c1e52c
to
431fcff
Compare
richard-ramos
force-pushed
the
rln-metrics
branch
from
8412bca
to
0029367
Compare
richard-ramos
force-pushed
the
rln-metrics
branch
from
0029367
to
ba0b513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds metrics to rln-relay. It uses the same of metrics defined in nwaku rln's impl