fix: missed passing protocols to addPeer #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
| @@ -260,7 +260,7 @@ func (pm *PeerManager) AddPeer(address ma.Multiaddr, origin wps.Origin, protocol | |||
| } | |||
|
|
|||
| //Add to the peer-store | |||
| err = pm.addPeer(info.ID, info.Addrs, origin) | |||
| err = pm.addPeer(info.ID, info.Addrs, origin, protocols...) | |||
There was a problem hiding this comment.
I think i did a lot of refactor while working on this code and might have missed this.
Please add some tests to verify such details so that we can catch these issues during unit tests itself.
There was a problem hiding this comment.
Will add that test as part of peerManager test refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Tests