Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add serviceSlot ds #684

Merged
merged 7 commits into from
Aug 30, 2023
Merged

feat: add serviceSlot ds #684

merged 7 commits into from
Aug 30, 2023

Conversation

harsh-98
Copy link
Contributor

@harsh-98 harsh-98 commented Aug 25, 2023 •
edited
Loading

Description

Related to #668

Changes

  • fix empty string peer that can be return when that peer is removed from serviceSlot.
  • add mutexes for thread safe ds.
  • add comments for servicePeer/relayPeers and inRelayPeer/outRelayPeers.

Tests

@status-im-auto
Copy link

status-im-auto commented Aug 25, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (48)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c1ae02e #1 2023-08-25 11:56:22 ~1 min linux 📦deb
✔️ c1ae02e #1 2023-08-25 11:57:05 ~1 min nix-flake 📄log
✖️ c1ae02e #1 2023-08-25 11:57:10 ~1 min tests 📄log
✖️ c1ae02e #1 2023-08-25 11:57:43 ~2 min tests 📄log
✔️ c1ae02e #1 2023-08-25 11:58:51 ~3 min android 📦tgz
✔️ c1ae02e #1 2023-08-25 12:15:39 ~20 min ios 📦tgz
✔️ 037faaa #2 2023-08-25 12:05:16 ~2 min linux 📦deb
✔️ 037faaa #2 2023-08-25 12:07:17 ~4 min nix-flake 📄log
✔️ 037faaa #2 2023-08-25 12:07:48 ~4 min android 📦tgz
✔️ 037faaa #2 2023-08-25 12:08:35 ~5 min tests 📄log
✔️ 037faaa #2 2023-08-25 12:09:23 ~6 min tests 📄log
✔️ 037faaa #2 2023-08-25 12:28:15 ~25 min ios 📦tgz
✔️ 135cab8 #3 2023-08-28 06:59:36 ~1 min linux 📦deb
✔️ 135cab8 #3 2023-08-28 07:00:14 ~1 min tests 📄log
✔️ 135cab8 #3 2023-08-28 07:00:16 ~1 min nix-flake 📄log
✔️ 135cab8 #3 2023-08-28 07:01:14 ~2 min tests 📄log
✔️ 135cab8 #3 2023-08-28 07:01:35 ~3 min android 📦tgz
✔️ 135cab8 #3 2023-08-28 07:02:31 ~4 min ios 📦tgz
✔️ 3f47ca8 #4 2023-08-28 07:11:56 ~34 sec linux 📦deb
✔️ 3f47ca8 #4 2023-08-28 07:12:41 ~1 min tests 📄log
✔️ 3f47ca8 #4 2023-08-28 07:13:12 ~1 min tests 📄log
✔️ 3f47ca8 #4 2023-08-28 07:13:16 ~1 min nix-flake 📄log
✔️ 3f47ca8 #4 2023-08-28 07:14:30 ~3 min android 📦tgz
✔️ 3f47ca8 #4 2023-08-28 07:15:06 ~3 min ios 📦tgz
✔️ 4dd5f49 #5 2023-08-28 10:30:33 ~37 sec linux 📦deb
✔️ 4dd5f49 #5 2023-08-28 10:31:22 ~1 min tests 📄log
✔️ 4dd5f49 #5 2023-08-28 10:31:54 ~1 min tests 📄log
✔️ 4dd5f49 #5 2023-08-28 10:31:56 ~1 min nix-flake 📄log
✔️ 4dd5f49 #5 2023-08-28 10:33:29 ~3 min android 📦tgz
✔️ 4dd5f49 #5 2023-08-28 10:35:20 ~5 min ios 📦tgz
✔️ 3972008 #6 2023-08-28 10:31:49 ~33 sec linux 📦deb
✔️ 3972008 #6 2023-08-28 10:32:48 ~1 min tests 📄log
✔️ 3972008 #6 2023-08-28 10:33:56 ~1 min nix-flake 📄log
✔️ 3972008 #6 2023-08-28 10:34:53 ~2 min tests 📄log
✔️ 3972008 #6 2023-08-28 10:36:44 ~3 min android 📦tgz
✔️ 3972008 #6 2023-08-28 10:40:55 ~9 min ios 📦tgz
✔️ dad527c #7 2023-08-29 09:46:02 ~1 min linux 📦deb
✔️ dad527c #7 2023-08-29 09:46:06 ~1 min tests 📄log
✔️ dad527c #7 2023-08-29 09:46:38 ~1 min tests 📄log
✔️ dad527c #7 2023-08-29 09:46:45 ~2 min nix-flake 📄log
✔️ dad527c #7 2023-08-29 09:48:25 ~3 min android 📦tgz
✔️ dad527c #7 2023-08-29 09:48:36 ~3 min ios 📦tgz
✔️ 63b7be5 #8 2023-08-30 07:44:30 ~32 sec linux 📦deb
✔️ 63b7be5 #8 2023-08-30 07:45:29 ~1 min tests 📄log
✔️ 63b7be5 #8 2023-08-30 07:45:54 ~1 min nix-flake 📄log
✔️ 63b7be5 #8 2023-08-30 07:47:50 ~3 min ios 📦tgz
✔️ 63b7be5 #8 2023-08-30 07:47:55 ~3 min android 📦tgz
✖️ 63b7be5 #8 2023-08-30 07:49:39 ~5 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fb7be03 #9 2023-08-30 09:38:31 ~32 sec linux 📦deb
✔️ fb7be03 #9 2023-08-30 09:39:22 ~1 min tests 📄log
✔️ fb7be03 #9 2023-08-30 09:40:00 ~2 min nix-flake 📄log
✔️ fb7be03 #9 2023-08-30 09:41:20 ~3 min android 📦tgz
✔️ fb7be03 #9 2023-08-30 09:41:43 ~3 min tests 📄log
✔️ fb7be03 #9 2023-08-30 09:41:53 ~3 min ios 📦tgz
✔️ e0d5ac0 #10 2023-08-30 11:53:41 ~1 min linux 📦deb
✔️ e0d5ac0 #10 2023-08-30 11:53:48 ~1 min tests 📄log
✔️ e0d5ac0 #10 2023-08-30 11:54:18 ~1 min tests 📄log
✔️ e0d5ac0 #10 2023-08-30 11:54:24 ~1 min nix-flake 📄log
✔️ e0d5ac0 #10 2023-08-30 11:55:56 ~3 min android 📦tgz
✔️ e0d5ac0 #10 2023-08-30 11:56:37 ~4 min ios 📦tgz

@harsh-98 harsh-98 force-pushed the ServiceSlot branch 2 times, most recently from 4dd5f49 to 3972008 Compare August 28, 2023 10:30
chaitanyaprem
chaitanyaprem reviewed Aug 29, 2023
View reviewed changes
waku/v2/peermanager/peer_manager.go Outdated Show resolved Hide resolved
waku/v2/peermanager/peer_manager.go Show resolved Hide resolved
waku/v2/peermanager/peer_manager.go Show resolved Hide resolved
waku/v2/peermanager/peer_manager.go Outdated Show resolved Hide resolved
waku/v2/peermanager/service_slot.go Show resolved Hide resolved
waku/v2/peermanager/service_slot.go Show resolved Hide resolved
waku/v2/peermanager/service_slot.go Outdated Show resolved Hide resolved
@chaitanyaprem chaitanyaprem mentioned this pull request Aug 30, 2023
Merged
@waku-org waku-org deleted a comment from 5lliot Aug 30, 2023
chaitanyaprem
chaitanyaprem approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from minor unresolved comment.

@harsh-98 harsh-98 merged commit accd9ff into master Aug 30, 2023
1 check passed
@harsh-98 harsh-98 deleted the ServiceSlot branch August 30, 2023 11:57
@harsh-98
Copy link
Contributor Author

#634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos richard-ramos is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harsh-98 @status-im-auto @chaitanyaprem