Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check nils when deleting subscription #691

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Check nils when deleting subscription #691

merged 2 commits into from
Aug 29, 2023

Conversation

cammellos
Copy link
Contributor

A bug reported during testing of the latest go waku, probably we should have some more linting/testing in place to catch these issues?

@cammellos cammellos self-assigned this Aug 28, 2023
@status-im-auto
Copy link

status-im-auto commented Aug 28, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1b7bfd3 #1 2023-08-28 17:46:30 ~1 min linux 📦deb
✔️ 1b7bfd3 #1 2023-08-28 17:47:19 ~2 min nix-flake 📄log
✔️ 1b7bfd3 #1 2023-08-28 17:48:16 ~3 min tests 📄log
✔️ 1b7bfd3 #1 2023-08-28 17:48:25 ~3 min tests 📄log
✔️ 1b7bfd3 #1 2023-08-28 17:49:13 ~4 min android 📦tgz
✔️ 1b7bfd3 #1 2023-08-28 17:49:26 ~4 min ios 📦tgz
✔️ 819113c #2 2023-08-29 10:48:10 ~1 min linux 📦deb
✔️ 819113c #2 2023-08-29 10:48:42 ~1 min tests 📄log
✔️ 819113c #2 2023-08-29 10:48:50 ~1 min nix-flake 📄log
✔️ 819113c #2 2023-08-29 10:49:52 ~2 min tests 📄log
✔️ 819113c #2 2023-08-29 10:50:11 ~3 min android 📦tgz
✔️ 819113c #2 2023-08-29 10:50:46 ~3 min ios 📦tgz

@cammellos cammellos mentioned this pull request Aug 28, 2023
Merged
@richard-ramos richard-ramos mentioned this pull request Aug 28, 2023
Merged
@cammellos cammellos merged commit 8ad08d6 into master Aug 29, 2023
2 checks passed
@cammellos cammellos deleted the bug/fix-panic-on-unsubscribe branch August 29, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-ramos richard-ramos richard-ramos approved these changes

@chaitanyaprem chaitanyaprem Awaiting requested review from chaitanyaprem chaitanyaprem is a code owner

Assignees

@cammellos cammellos

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cammellos @status-im-auto @richard-ramos