Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rest api errors #919

Merged
merged 8 commits into from
Nov 24, 2023
Merged

fix: rest api errors #919

merged 8 commits into from
Nov 24, 2023

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Nov 22, 2023

Description

Fixes issues reported in #914 .
Also added additional logs for easy debugging.

Changes

  • Return 4xx instead of 5xx where appropriate
  • Add some logs

Tests

@status-im-auto
Copy link

status-im-auto commented Nov 22, 2023

Jenkins Builds

Click to see older builds (20)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e511d22 #1 2023-11-22 08:09:38 ~1 min nix-flake 📄log
✔️ e511d22 #1 2023-11-22 08:10:10 ~2 min linux 📦deb
✖️ e511d22 #1 2023-11-22 08:10:54 ~3 min tests 📄log
✔️ e511d22 #1 2023-11-22 08:11:37 ~3 min android 📦tgz
✔️ e511d22 #1 2023-11-22 08:11:42 ~4 min ios 📦tgz
✖️ e511d22 #1 2023-11-22 08:11:43 ~4 min tests 📄log
✔️ a289e2f #2 2023-11-22 08:11:24 ~1 min linux 📦deb
✔️ a289e2f #2 2023-11-22 08:11:35 ~1 min nix-flake 📄log
✖️ a289e2f #2 2023-11-22 08:12:41 ~1 min tests 📄log
✔️ a289e2f #2 2023-11-22 08:13:45 ~4 min ios 📦tgz
✔️ a289e2f #2 2023-11-22 08:15:15 ~3 min android 📦tgz
✖️ a289e2f #2 2023-11-22 08:15:33 ~3 min tests 📄log
✔️ 6e88ab4 #3 2023-11-22 10:36:53 ~1 min tests 📄log
✔️ 6e88ab4 #3 2023-11-22 10:37:08 ~1 min linux 📦deb
✔️ 6e88ab4 #3 2023-11-22 10:37:50 ~1 min nix-flake 📄log
✔️ 6e88ab4 #3 2023-11-22 10:39:07 ~3 min ios 📦tgz
✔️ 6e88ab4 #3 2023-11-22 10:39:13 ~3 min android 📦tgz
✔️ 6e88ab4 #3 2023-11-22 10:40:00 ~4 min tests 📄log
✔️ 1cff5ae #4 2023-11-22 15:25:26 ~1 min nix-flake 📄log
✔️ 56ad0bd #5 2023-11-23 23:21:20 ~2 min nix-flake 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d88a83a #6 2023-11-24 01:24:06 ~1 min nix-flake 📄log
✔️ 64e04cf #7 2023-11-24 03:56:10 ~1 min nix-flake 📄log

cmd/waku/server/rest/relay.go Dismissed Show dismissed Hide dismissed
@chaitanyaprem
Copy link
Collaborator Author

@richard-ramos , not sure why but the postgres test keeps failing even if try to rerun the action.
Can you please take a look? I don't think it is realted to my changes.

Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/waku/server/rest/relay.go Show resolved Hide resolved
cmd/waku/server/rest/relay.go Outdated Show resolved Hide resolved
@richard-ramos
Copy link
Member

richard-ramos commented Nov 23, 2023

2023/11/22 15:27:43 an error 'failed to connect to host=localhost user=postgres database=template1: failed to receive message (read tcp [::1]:58578->[::1]:5432: read: connection reset by peer)' while reseting the db

seems like we do not handle reconnects :( reopening #745 to track this

@chaitanyaprem chaitanyaprem merged commit d7249fc into master Nov 24, 2023
12 checks passed
@chaitanyaprem chaitanyaprem deleted the fix/rest-api-errors branch November 24, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants