adr: added message uid document #18
Conversation
There was a problem hiding this comment.
lgtm.
as an opinion, I think its valuable to start such documents with few lines where its crystal clear what's being introduced, right at the begining. "this introduces message uid, calculated as follows, with this and this".
then ellaborate on rationale, tradeoffs, use cases, etc as you are doing.
just matter of ordering to allow 3rd parties to easily grasp the idea of it.
| message_id: [u8; 32] = sha256(WakuMessageBuffer) | ||
| ``` | ||
|
|
||
| These structures provide a limited-time message deduplication capability o keep the memory footprint low. The *Message Cache* provides a short-term deduplication capability (~5 heartbeat periods). The **Seen Cache,** implemented as a bloom filter, provides a longer-term deduplication capability (~2 minutes). |
| It is a computable 32 bytes fixed-length checksum based on the content of the Waku Message. It is defined as follows: | ||
|
|
||
| ```rust | ||
| checksum: [u8; 32] = sha256(network_topic, WakuMessage.topic, WakuMessage.meta, WakuMessage.payload) |
There was a problem hiding this comment.
for the v3, but this was my point in the previous call.
if we sign the checksum and include it in the new (64 bytes) meta field, then the checksum can't include meta. Unless ofc we sign something else.
This document was posted two months ago in #9 before the DoS protection initiative was kicked off. It would have been great if you had provided some feedback by that time. I hope that reading now the document helps understand the ideas behind the Please, wait for the next version of this document for further changes. |
Added Message Unique ID (v2) to the waku pm repository. Note that this is just a design document, non-normative.
This ADR is associated with issue #9