Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure that the default credentials chain is used for S3 authentication #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kujon
Copy link

@kujon kujon commented Feb 13, 2020

Addresses wal-g/wal-g#562

@x4m
Copy link

x4m commented Feb 14, 2020

@perekalov can you please take a look here?
Basically, I understand that all removed code is trying to do S3 SDK's job, but... it is doing it in a different way.

@kujon
Copy link
Author

kujon commented Feb 14, 2020

@x4m I still need to get it to work first 😅 I'm new to golang, so it's taking a while.

@kujon
Copy link
Author

kujon commented Feb 17, 2020

Seems to be working ok rn, based on my limited set of test conditions.

@kujon kujon marked this pull request as ready for review February 17, 2020 22:15
@x4m
Copy link

x4m commented Feb 18, 2020

we are currently considering moving storages back under github/wal-g/wal-g
so that storages would be tests with regular WAL-G CI too. If this hapens, will it be problematic for you to move your PR there?

@kujon
Copy link
Author

kujon commented Feb 18, 2020

not at all.

@usernamedt
Copy link
Member

Hi!

This repository is going to be merged into the wal-g main repo. Please submit any future updates to the main repository.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants