AnalysisScope example #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
reviewed
Oct 17, 2021
src/main/java/com/ibm/wala/examples/AnalysisScopeExamples/AnalysisScopeExamples.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/wala/examples/AnalysisScopeExamples/AnalysisScopeExamples.java
Outdated
Show resolved
Hide resolved
msridhar
reviewed
Oct 24, 2021
src/main/java/com/ibm/wala/examples/AnalysisScopeExamples/AnalysisScopeExamples.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/wala/examples/AnalysisScopeExamples/AnalysisScopeExamples.java
Outdated
Show resolved
Hide resolved
msridhar
requested changes
Nov 1, 2021
| //for more information, please check out https://github.com/wala/WALA/wiki/Analysis-Scope | ||
|
|
||
|
|
||
| public class analysisscope { |
There was a problem hiding this comment.
Suggested change
| public class analysisscope { | |
| public class AnalysisScopeExamples { |
Class names start with a capital and use camel case. See https://google.github.io/styleguide/javaguide.html#s5.2.2-class-names
| public class analysisscope { | ||
| /** | ||
| * @param classPath paths of jars to include in analysis scope, formatted as a Java classpath | ||
| * @return AnaylsisScope object created by makeJavaBinaryAnalysisScope |
There was a problem hiding this comment.
Suggested change
| * @return AnaylsisScope object created by makeJavaBinaryAnalysisScope | |
| * @return AnalysisScope object created by makeJavaBinaryAnalysisScope |
| * @return return an analysis scope object | ||
| * @throws IOException | ||
| */ | ||
| AnalysisScope makeAnalysisScope(String classPath, String exceptionFile) throws IOException{ |
There was a problem hiding this comment.
The first parameter should be named something like scopeFilePath, and the second should be exclusionsFilePath
| */ | ||
| AnalysisScope makeAnalysisScope(String classPath, String exceptionFile) throws IOException{ | ||
| File exception = new File(exceptionFile); | ||
| return AnalysisScopeReader.readJavaScope(classPath, exception, null); |
There was a problem hiding this comment.
Suggested change
| return AnalysisScopeReader.readJavaScope(classPath, exception, null); | |
| return AnalysisScopeReader.readJavaScope(classPath, exception, AnalysisScopeExamples.class.getClassLoader()); |
Should pass a real classloader as the final parameter.
| import java.io.IOException; | ||
| import com.ibm.wala.util.config.AnalysisScopeReader; | ||
|
|
||
| //for more information, please check out https://github.com/wala/WALA/wiki/Analysis-Scope |
There was a problem hiding this comment.
Write this as proper Javadoc on the class rather than just a single line comment
msridhar
reviewed
Nov 8, 2021
| /** | ||
| * | ||
| * @param scopeFilePath Location of a scope file in string form | ||
| * @param exceptionFilePath location of an exception file |
There was a problem hiding this comment.
Everywhere you write exception it should be exclusion. These files give a pattern of which Java packages to exclude from the scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.