Prevent duplicate download, fix indents

waldronlab · Oct 7, 2024 · ad64592 · ad64592
1 parent d37a750
commit ad64592
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/R/cache.R b/R/cache.R
@@ -50,15 +50,15 @@
 #' @noRd
 .download_and_cache <- function(url, quietly = TRUE) {
     bfc <- .get_cache()
-    rid <- bfcquery(bfc, url)$rid
+    rid <- bfcquery(bfc, url, "rname")$rid
     if (!length(rid)) {
         if (!quietly) {
             inform(paste("Downloading", url, "..."))
         }
-        rid <- names(bfcadd(bfc, url))
-    }
-    if (!isFALSE(bfcneedsupdate(bfc, rid))) {
-        bfcdownload(bfc, rid, ask = FALSE)
+        rid <- names(bfcadd(bfc,
+            rname = url, fpath = url, rtype = "web",
+            download = TRUE, verbose = !quietly
+        ))
     }
     bfcrpath(bfc, rids = rid)
 }
diff --git a/vignettes/bedbaser.Rmd b/vignettes/bedbaser.Rmd
@@ -133,7 +133,7 @@ bb_to_granges(api, bed_id)
 
 ```{r bb_to_granges_big_bed}
 ex_bed <- bb_example(api, "bed")
-bb_to_granges(api, ex_bed$id, "bigbed")
+bb_to_granges(api, ex_bed$id, "bigbed", quietly = FALSE)
 ```
 
 ## Import a BEDset into a GRangesList