Enhance de #442
Enhance de #442
Conversation
| }); | ||
| }); | ||
|
|
||
| // test("Test - Strict mode", function () { |
There was a problem hiding this comment.
Please don't leave the commented out code like this.
If we don't have DE strict mode, let's remove it.
| }); | ||
| }); | ||
|
|
||
| //test("Test - Nested time ago", function () { |
There was a problem hiding this comment.
Same as previous comment about not leaving commented code.
If we are not ready to support the nested time ref, lets remove this and add it later.
| } | ||
|
|
||
| const unit = TIME_UNIT_DICTIONARY[match[4].toLowerCase()]; | ||
| let timeUnits = {}; |
There was a problem hiding this comment.
Nit: first, I'd rename num to value and I think let timeUnits = { unit: num }; is clearer to understand.
|
Hey @georgd. Thanks for the improvement! |
|
Hey @georgd, this is really useful! In case you currently don’t have time to continue on this would you be fine if I would pick up this PR? |
|
Hi, indeed I sadly won't have time for this for another couple of months, as it seems. I'd be happy to hand this over to you 😀 |
|
Back then, I started refactoring the code to bring the DE part on par with EN but I am better with regex than with js so didn't get far in the little time I had. When I find the time, would you mind me proposing improvements? |
|
I'm not sure how much time I'll have. But probably it won't take a couple of months 😄
Sure! |
No description provided.