Add docs for Docker Hub repo support in Advanced Agent set up #760
Conversation
|
@KyleGoyette Is this PR ready for review, merge? |
| destination: <organization|user>/<repo-name> | ||
| # If using Kaniko, specify the PVC or cloud bucket where the agent can store the | ||
| # build context. | ||
| build-context-store: <PVC | cloud bucket> |
There was a problem hiding this comment.
You're not supposed to specify a pvc here, you just do it via the helm chart. We need to know the pvc name and where it is mounted in the agent pod and that gets passed through environment variables set in the chart
There was a problem hiding this comment.
So.... if a PVC is specified in the helm chart leave this blank?
There was a problem hiding this comment.
Yeah this should be left blank. This relates to the coupling of the agent config and helm chart. Users control the literal contents of the agent config as a chart variable and provide a pvc name as another chart variable. Because they control the literal contents I think it would be weird for us to inject the pvc name into the agent config. Or ask them to write it in both places.
There was a problem hiding this comment.
In retrospect it would be better to have helm variables for the agent config fields and then construct that config in the agent pod for the user.
Deploying docodile with
|
| Latest commit: |
22bd0c6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09dd5cbc.docodile.pages.dev |
| Branch Preview URL: | https://launch-dockerhub-repo.docodile.pages.dev |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -23,7 +23,7 @@ The Launch agent can build images using [Docker](https://docs.docker.com/) or [K | |||
| * Kaniko: builds a container image in Kubernetes without running the build as a privileged container. | |||
| * Docker: builds a container image by executing a `docker build` command locally. | |||
|
|
|||
| The builder type can be controlled by the `builder.type` key in the launch agent config to either `docker`, `kaniko`, or `noop` to disable build. By default, the agent helm chart sets the `builder.type` to `noop`. Additional keys in the `builder` section will be used to configure the build process. | |||
| The builder type can be controlled by the `builder.type` key in the launch agent config to either `docker`, `kaniko`, or `noop` to disable build. By default, the agent Helm chart sets the `builder.type` to `noop`. Additional keys in the `builder` section will be used to configure the build process. | |||
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('be controlled').
| @@ -23,7 +23,7 @@ | |||
| * Kaniko: builds a container image in Kubernetes without running the build as a privileged container. | |||
| * Docker: builds a container image by executing a `docker build` command locally. | |||
|
|
|||
| The builder type can be controlled by the `builder.type` key in the launch agent config to either `docker`, `kaniko`, or `noop` to disable build. By default, the agent helm chart sets the `builder.type` to `noop`. Additional keys in the `builder` section will be used to configure the build process. | |||
| The builder type can be controlled by the `builder.type` key in the launch agent config to either `docker`, `kaniko`, or `noop` to disable build. By default, the agent Helm chart sets the `builder.type` to `noop`. Additional keys in the `builder` section will be used to configure the build process. | |||
There was a problem hiding this comment.
[Google.WordList] Use 'turn off' or 'off' instead of 'disable'.
| @@ -23,7 +23,7 @@ | |||
| * Kaniko: builds a container image in Kubernetes without running the build as a privileged container. | |||
| * Docker: builds a container image by executing a `docker build` command locally. | |||
|
|
|||
| The builder type can be controlled by the `builder.type` key in the launch agent config to either `docker`, `kaniko`, or `noop` to disable build. By default, the agent helm chart sets the `builder.type` to `noop`. Additional keys in the `builder` section will be used to configure the build process. | |||
| The builder type can be controlled by the `builder.type` key in the launch agent config to either `docker`, `kaniko`, or `noop` to disable build. By default, the agent Helm chart sets the `builder.type` to `noop`. Additional keys in the `builder` section will be used to configure the build process. | |||
There was a problem hiding this comment.
[Google.Will] Avoid using 'will'.
| @@ -23,7 +23,7 @@ | |||
| * Kaniko: builds a container image in Kubernetes without running the build as a privileged container. | |||
| * Docker: builds a container image by executing a `docker build` command locally. | |||
|
|
|||
| The builder type can be controlled by the `builder.type` key in the launch agent config to either `docker`, `kaniko`, or `noop` to disable build. By default, the agent helm chart sets the `builder.type` to `noop`. Additional keys in the `builder` section will be used to configure the build process. | |||
| The builder type can be controlled by the `builder.type` key in the launch agent config to either `docker`, `kaniko`, or `noop` to disable build. By default, the agent Helm chart sets the `builder.type` to `noop`. Additional keys in the `builder` section will be used to configure the build process. | |||
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('be used').
Summary
|
|
Closing. Launch is being deprecated. |
Description
What does the pull request do? If it fixes a bug or resolves a feature request, be sure to link to that issue.
Screenshot for 👁️
Ticket
Does this PR fix an existing issue? If yes, provide a link to the ticket here:
Checklist
Check if your PR fulfills the following requirements. Put an
Xin the boxes that apply.yarn start. My changes did not break the local preview.yarn docusaurus build) was run locally and successfully without errors or warnings.maininto my feature branch before submitting this PR.