expose wasmtime_provider::WasmtimeEngineProviderPre
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the `WasmtimeEngineProviderPre` struct public. This allows end users of the wasmtime provider crate to optimize the way they create and store `WasmtimeEngineProvider` objects. Signed-off-by: Flavio Castelli <[email protected]>
Upgrade to 1.74 and fix the new linter warnings. Signed-off-by: Flavio Castelli <[email protected]>
|
@pkedy , @jsoverson : could you please take a look at this PR and, if merged, tag a new release of the wasmtime provider? 🙏 |
|
Happy new year, @flavio ! |
|
@pkedy thanks for the release and happy new year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
wasmtime_provider::WasmtimeEngineProviderPrepublic. This allows end users to implement optimizations inside of their code base.On top of that, update to latest Rust release and fix some small linter warnings caused by that.
Once this PR is merged it would be great to release a new minor version of the
wasmtime_providercrate (a minor release since the API is changed by the introduction of this new public struct).