Dependencies reduction #350
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkiros
force-pushed
the
dependencies_reduction
branch
from
6dcfe41
to
51d95d8
Compare
Darkiros
force-pushed
the
dependencies_reduction
branch
from
51d95d8
to
fb5e2d0
Compare
Darkiros
commented
Nov 24, 2022
Comment on lines
+73
to
+76
| ssl = [ | ||
| "humanize==4.4.0", | ||
| "sslyze==5.0.6" | ||
| ] |
There was a problem hiding this comment.
@polyedre what do you think about it ? Is it better to install ssl module like that ?
polyedre
reviewed
Nov 28, 2022
There was a problem hiding this comment.
I am not convinced by these changes:
- You duplicated the packages and versions in one additional file. Two files are already too much, but 3... (requirements.txt, pyproject.toml and Pipfile)
- You added a lot of explicit packages. This may cause dependency headaches in the future. And that's already the case ;)
If this change can only save about 10MB, I think it is not worth increasing the maintenance cost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce dependencies to the minimum required.