[BUG] Fix issue where string bodies were not parsed or compared correctly #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkajla12
reviewed
Aug 14, 2024
kkajla12
reviewed
Aug 14, 2024
| "request": { | ||
| "method": "POST", | ||
| "url": "/users", | ||
| "body": "{{ test1.userId }}" |
There was a problem hiding this comment.
Is using a template variable in the request body intentional here? Or is it intended to be a simple string?
There was a problem hiding this comment.
Sorry I meant to do this in the response body, but it was before I fixed the string issue. I'll change it.
kkajla12
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: String bodies would include escaped quotes in request data (
"\"Hello, World!\"")Fix: Do not
json.Marshalbody if it is of string typeIssue: String response bodies were only parsed as JSON objects
Fix: If
json.Unmarshalfails and body is a string, compare as a string.Other enhancements:
switchstatement in response comparer code to make it slightly more readable