feat: Expose decode_seed functionality #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonas
requested review from
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
thomastaylor312
requested changes
Jun 17, 2024
Signed-off-by: Joonas Bergius <[email protected]>
joonas
force-pushed
the
feat/expose-decode_seed-functionality
branch
from
7e8ca24 to
43404b8
Compare
thomastaylor312
approved these changes
Jun 18, 2024
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This renames and exposes pre-existing
from_seedfunction asdecode_seedto mirror the Go nkeys library'sDecodeSeedfunctionality.Depending on whether we would prefer to provide higher level abstractions or stick closer to the spiritual implementation of the Go library's implementation, I realize there may be preference to provide access to the underlying
SigningKey, which could work just as well, it just creates the need for an unnecessary step of having to first create a KeyPair from the seed, only to then turn it into something else.Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification