feat(status)!: rename compensating and ready status #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
connorsmith256
as code owners
brooksmtownsend
force-pushed
the
feat/rename-statuses
branch
from
d27c947 to
a139d1e
Compare
connorsmith256
previously approved these changes
Nov 28, 2023
Signed-off-by: Brooks Townsend <[email protected]> chore: update to lowercase Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/rename-statuses
branch
from
a139d1e to
5b75031
Compare
connorsmith256
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR renames the
Compensatingstatus toReconciling, and theReadystatus toDeployed. According to discussion in #177 this is what most folks agreed was more intuitive than what we had, and Undeployed/Failed are still acceptable statuses.Related Issues
Fixes #177
Release Information
Next minor release
Consumer Impact
Downstream consumers of the wadm crate will be able to simply replace all uses of compensating and ready to the new status enum member. Any consumers of the status stream that look for a specific status message will need to update to use the new status.
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification