fix: detect spread scaler requirements violation #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed <[email protected]>
fix spelling error Co-authored-by: Brooks Townsend <[email protected]> Signed-off-by: Ahmed <[email protected]>
…conflicts Signed-off-by: Ahmed <[email protected]>
ahmedtadde
force-pushed
the
fix/component-spreadscaler-infinite-reconcialiation-loop
branch
from
9804e81 to
31c2a19
Compare
…eq. conflict stuff Signed-off-by: Ahmed <[email protected]>
Signed-off-by: Ahmed <[email protected]>
brooksmtownsend
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
A
ComponentSpreadScalerconfig may have a set of requirements which cannot fully be satisfied so the deployment status remains as "Reconciling".Related Issues
#432
Release Information
nextConsumer Impact
This is an enhancement/correctness change. It should have no adverse effect on existing functionality. This change prevents potential
Heisenbugswherewadmcould potentially operate on faulty instance spread without any detection.Testing
All existing tests (unit and e2e) are functional
Unit Test(s)
Added two test cases
can_detect_spread_requirements_violation_1andcan_detect_spread_requirements_violation_2