Working WASIX API #325
Closed
Working WASIX API #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # Cargo.toml # pkg/wasmer_wasi_js.js # pkg/wasmer_wasi_js_bg.wasm
The global `Buffer` is used for loading base64 encoded string. However, this **implicit** and **global** dependency makes some confusions and problems (#294, #305, and ruby/ruby.wasm#182). The use of `Buffer` here is limited, so we can easily replace this by using `atob` function. This simplifies user's build settings and reduces the file size since there is no need to include Buffer.
update ci
|
Hey @WanderLanz , this PR is awesome work. We want to add some of the bits of it back into the Wasmer repo (so it's available for anyone trying to compile Wasmer to the browser), but most of the glue things that you created look great. Really good work on updating everything, including reworking current tests. We'll probably rebase your PR with the new one once things get merged upstream. |
|
@syrusakbary Awesome! I'm glad it'll be of help, hopefully everything goes well. |
|
Hey just checking back in, it seems like @`Michael-F-Bryan already got the useful parts in the wasix branch, I'll go ahead and close this. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before any consideration for merging, compatibility with
@wasmer/wasiis broken, so the package under@wasmer/wasixto prevent accidental breakage. No consideration was made to make it 1-1 compatible.I tried to stay as close as possible to
wasi-webin hopes of being able to just copy/sync in the future.Added
Changed
Todo