Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci #326

Closed
wants to merge 11 commits into from
Closed

Ci #326

wants to merge 11 commits into from

Conversation

WanderLanz
Copy link

No description provided.

syrusakbary and others added 11 commits February 16, 2023 22:57
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	pkg/wasmer_wasi_js.js
#	pkg/wasmer_wasi_js_bg.wasm
The global `Buffer` is used for loading base64 encoded string.
However, this **implicit** and **global** dependency makes some
confusions and problems (#294, #305, and ruby/ruby.wasm#182).

The use of `Buffer` here is limited, so we can easily replace this
by using `atob` function. This simplifies user's build settings
and reduces the file size since there is no need to include Buffer.
@WanderLanz WanderLanz closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants